Re: [PATCH] RDMA/rds: remove unused struct 'rds_ib_dereg_odp_mr'

[Dr. David Alan Gilbert]

* Leon Romanovsky (leon@xxxxxxxxxx) wrote:
> On Sun, Jul 21, 2024 at 11:02:49AM +0000, Dr. David Alan Gilbert wrote:
> > * Leon Romanovsky (leon@xxxxxxxxxx) wrote:
> > > On Sat, Jul 20, 2024 at 12:28:17AM +0000, Dr. David Alan Gilbert wrote:
> > > > * Allison Henderson (allison.henderson@xxxxxxxxxx) wrote:
> > > > > On Sat, 2024-06-01 at 00:33 +0100, linux@xxxxxxxxxxx wrote:
> > > > > > From: "Dr. David Alan Gilbert" <linux@xxxxxxxxxxx>
> > > > > > 
> > > > > > 'rds_ib_dereg_odp_mr' has been unused since the original
> > > > > > commit 2eafa1746f17 ("net/rds: Handle ODP mr
> > > > > > registration/unregistration").
> > > > > > 
> > > > > > Remove it.
> > > > > > 
> > > > > > Signed-off-by: Dr. David Alan Gilbert <linux@xxxxxxxxxxx>
> > > > > 
> > > > > This patch looks fine to me, the struct is indeed unused at this point.
> > > > > Thanks for the clean up!
> > > > > 
> > > > > Reviewed-by: Allison Henderson <allison.henderson@xxxxxxxxxx>
> > > > 
> > > > Hi,
> > > >   Does anyone know who might pick this one up - I don't think
> > > > it's in -next yet?
> > > 
> > > 1. We are in merge window and this patch is not a bug fix, so it should
> > >    wait until the next merge window.
> > 
> > Yeh I did wonder; it was posted and reviewed back at the start of June.
> > 
> > > 2. Title should be net/rds ... and not RDMA/rds ...
> > 
> > OK, I can easily fix that.
> > 
> > > 3. netdev is closed right now, so it should be resubmitted after next merge
> > >    window ends.
> > 
> > When you say 'resubmitted' - you mean reposted to the lists with the amended
> > title? Or what?
> 
> Yes, reposted to the netdev@ ML with the correct title.

OK, reposted as
Message-ID: 20240729210114.48522-1-linux@xxxxxxxxxxx

Dave

> Thanks
> 
> > 
> > Dave
> > 
> > > Thanks
> > > 
> > -- 
> >  -----Open up your eyes, open up your mind, open up your code -------   
> > / Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
> > \        dave @ treblig.org |                               | In Hex /
> >  \ _________________________|_____ http://www.treblig.org   |_______/
> 
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/