Re: [PATCH v11 25/27] ARM: dts: aspeed: yosemite4: add RTQ6056 support
From: Patrick Williams
Date: Mon Jul 29 2024 - 18:03:38 EST
On Tue, Jul 23, 2024 at 05:23:06PM +0800, Delphine CC Chiu wrote:
> Add RTQ6056 (spider board 3rd source) support in yosemite4 DTS.
>
> Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@xxxxxxxxxx>
> ---
> .../boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts
> index f73719b3c2f1..03a1e41312e3 100644
> --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts
> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts
> @@ -1240,35 +1240,35 @@ adc@37 {
> };
>
> power-sensor@40 {
> - compatible = "ti,ina233";
> + compatible = "ti,ina233", "richtek,rtq6056";
Is this legal to have two chips both listed as compatible? I thought
this approach has been rejected before.
> reg = <0x40>;
> resistor-calibration = /bits/ 16 <0x0a00>;
> current-lsb= /bits/ 16 <0x0001>;
> };
>
> power-sensor@41 {
> - compatible = "ti,ina233";
> + compatible = "ti,ina233", "richtek,rtq6056";
> reg = <0x41>;
> resistor-calibration = /bits/ 16 <0x0a00>;
> current-lsb= /bits/ 16 <0x0001>;
> };
>
> power-sensor@42 {
> - compatible = "ti,ina233";
> + compatible = "ti,ina233", "richtek,rtq6056";
> reg = <0x42>;
> resistor-calibration = /bits/ 16 <0x0a00>;
> current-lsb= /bits/ 16 <0x0001>;
> };
>
> power-sensor@43 {
> - compatible = "ti,ina233";
> + compatible = "ti,ina233", "richtek,rtq6056";
> reg = <0x43>;
> resistor-calibration = /bits/ 16 <0x0a00>;
> current-lsb= /bits/ 16 <0x0001>;
> };
>
> power-sensor@44 {
> - compatible = "ti,ina233";
> + compatible = "ti,ina233", "richtek,rtq6056";
> reg = <0x44>;
> resistor-calibration = /bits/ 16 <0x0a00>;
> current-lsb= /bits/ 16 <0x0001>;
> --
> 2.25.1
>
--
Patrick Williams
Attachment:
signature.asc
Description: PGP signature