Re: [PATCH RESEND v2 0/2] ARM: dts: bcm-mobile: Split out nodes used by both BCM21664 and BCM23550

[Florian Fainelli]

On 7/29/24 05:34, Artur Weber wrote:
> The BCM21664 and BCM23550 are nearly identical to each other in terms
> of register layout. This was verified against a downstream kernel[1] -
> Broadcom's kernel has "RDB" directories which includes headers with
> the full register maps for the included hardware. Running:
>
>    diff --recursive arch/arm/mach-{hawaii,java}/include/mach/rdb
>
> reveals that the differences are minuscule - some things related to
> ISP and H264 decoding. Most of the other differences are related to
> the different CPUs in the two chipsets - the BCM21664 has 2x Cortex-A9
> cores, and the BCM23550 has 4x Cortex-A7 cores.
>
> In mainline, most drivers are also re-used between the two.
>
> To make development for both platforms easier, split out the common
> nodes into a separate DTSI, bcm2166x-common.dtsi. This only leaves
> the device-specific nodes - so, CPU and related things - in the SoC-
> specific DTSIs (bcm21664.dtsi and bcm23550.dtsi).
>
> The new DTSI is based off the bcm23550.dtsi, with its split into
> busses. Since it's pretty much 99% identical, I kept the licensing
> of the original file (BSD 3-clause). The license for the bcm21664.dtsi
> file remains GPL 2.0 as it originally was.
>
> make CHECK_DTBS=y on bcm21664-garnet.dtb and bcm23550-sparrow.dtb
> seem to pass fine for me (thanks to Stanislav Jakubek for converting
> the bindings to YAML format!).
>
> [1] https://github.com/knuxdroid/android_kernel_samsung_baffinlite
>
> Signed-off-by: Artur Weber <aweber.kernel@xxxxxxxxx>

Thanks for resending, I had those on my radar to push out, now done!

Applied to https://github.com/Broadcom/stblinux/commits/devicetree/next
--
Florian