Re: [PATCH net-next 5/9] net: dsa: vsc73xx: use mutex to mdio operations

[Andrew Lunn]

On Mon, Jul 29, 2024 at 11:06:11PM +0200, Pawel Dembicki wrote:
> vsc73xx needs mutex during mdio bus access to avoid races. Without it,
> phys are misconfigured and bus operations aren't work as expected.

This is adding much more than a mutex.

The mdio core already has a mutex, so there should not be multiple
parallel operations going on. So i don't think the mutex itself is the
fix. It is more likely to be a change in the timing. Which in itself
is not good. Maybe use your new vsc73xx_mdio_busy_check() with one of
the helpers in include/linux/iopoll.h

    Andrew

---
pw-bot: cr