Re: [PATCH] tracing: Use refcount for trace_event_file reference counter

From: Google
Date: Mon Jul 29 2024 - 20:02:34 EST


On Mon, 29 Jul 2024 19:02:41 -0400
Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:

> On Mon, 29 Jul 2024 23:49:24 +0900
> Masami Hiramatsu (Google) <mhiramat@xxxxxxxxxx> wrote:
>
> > On Fri, 26 Jul 2024 14:42:08 -0400
> > Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
> >
> > > From: Steven Rostedt <rostedt@xxxxxxxxxxx>
> > >
> > > Instead of using an atomic counter for the trace_event_file reference
> > > counter, use the refcount interface. It has various checks to make sure
> > > the reference counting is correct, and will warn if it detects an error
> > > (like refcount_inc() on '0').
> > >
> > > Signed-off-by: Steven Rostedt (Google) <rostedt@xxxxxxxxxxx>
> >
> > Looks good to me.
> >
> > Masami Hiramatsu (Google) <mhiramat@xxxxxxxxxx>
>
> Is that an ack or a review? ;-)

It was Ack,

Acked-by: Masami Hiramatsu (Google) <mhiramat@xxxxxxxxxx>

Sorry about that. I might be too sleep.

>
> -- Steve
>


--
Masami Hiramatsu (Google) <mhiramat@xxxxxxxxxx>