Re: kernel/iomem.c:18:32: sparse: sparse: cast truncates bits from constant value (38400000050e becomes 50e)

From: Baoquan He
Date: Mon Jul 29 2024 - 23:23:53 EST

Next message: Hailong Liu: "Re: [RFC PATCH v2] mm/vmalloc: fix incorrect __vmap_pages_range_noflush() if vm_area_alloc_pages() from high order fallback to order0"
Previous message: Xiu Jianfeng: "Re: [PATCH v5 2/5] cgroup/pids: Make event counters hierarchical"
In reply to: kernel test robot: "kernel/iomem.c:18:32: sparse: sparse: cast truncates bits from constant value (38400000050e becomes 50e)"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On 07/28/24 at 10:43pm, kernel test robot wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head: 5437f30d3458ad36e83ab96088d490ebfee844d8
> commit: 0453c9a78015cb2219cda7239d881f4e3137bff8 sh: mm: convert to GENERIC_IOREMAP
> date: 12 months ago
> config: sh-randconfig-r133-20240727 (https://download.01.org/0day-ci/archive/20240728/202407282201.lk1cNoMd-lkp@xxxxxxxxx/config)
> compiler: sh4-linux-gcc (GCC) 14.1.0
> reproduce: (https://download.01.org/0day-ci/archive/20240728/202407282201.lk1cNoMd-lkp@xxxxxxxxx/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@xxxxxxxxx>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202407282201.lk1cNoMd-lkp@xxxxxxxxx/

I every tried to fix this when I got this report one year ago. The thing
is I found there are many places like this. I am not sure if it's worth
doing the type casting to satisfy sparse. And the type casting makes
very long line of code and reduce readibility.

If this is confirmed worth, I can post patch to fix them.

>
> sparse warnings: (new ones prefixed by >>)
> kernel/iomem.c:113:22: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected void *[assigned] addr @@ got void [noderef] __iomem * @@
> kernel/iomem.c:113:22: sparse: expected void *[assigned] addr
> kernel/iomem.c:113:22: sparse: got void [noderef] __iomem *
> kernel/iomem.c:116:22: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected void *[assigned] addr @@ got void [noderef] __iomem * @@
> kernel/iomem.c:116:22: sparse: expected void *[assigned] addr
> kernel/iomem.c:116:22: sparse: got void [noderef] __iomem *
> >> kernel/iomem.c:18:32: sparse: sparse: cast truncates bits from constant value (38400000050e becomes 50e)
> kernel/iomem.c: note: in included file (through include/linux/gfp.h, include/linux/xarray.h, include/linux/radix-tree.h, ...):
> include/linux/mmzone.h:1997:40: sparse: sparse: self-comparison always evaluates to false
> --
> arch/sh/boards/board-sh7785lcr.c:298:13: sparse: sparse: symbol 'init_sh7785lcr_IRQ' was not declared. Should it be static?
> arch/sh/boards/board-sh7785lcr.c:322:11: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected unsigned char *p @@ got void [noderef] __iomem * @@
> arch/sh/boards/board-sh7785lcr.c:322:11: sparse: expected unsigned char *p
> arch/sh/boards/board-sh7785lcr.c:322:11: sparse: got void [noderef] __iomem *
> >> arch/sh/boards/board-sh7785lcr.c:328:17: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void volatile [noderef] __iomem *addr @@ got unsigned char *p @@
> arch/sh/boards/board-sh7785lcr.c:328:17: sparse: expected void volatile [noderef] __iomem *addr
> arch/sh/boards/board-sh7785lcr.c:328:17: sparse: got unsigned char *p
> arch/sh/boards/board-sh7785lcr.c: note: in included file (through arch/sh/include/asm/io.h, include/linux/io.h, include/linux/irq.h, ...):
> >> include/asm-generic/io.h:1089:41: sparse: sparse: cast truncates bits from constant value (384000000506 becomes 506)
> --
> drivers/spi/spi-sh-sci.c: note: in included file (through arch/sh/include/asm/io.h, include/linux/scatterlist.h, include/linux/spi/spi.h):
> >> include/asm-generic/io.h:1089:41: sparse: sparse: cast truncates bits from constant value (384000000506 becomes 506)
> --
> drivers/spi/spi-nxp-fspi.c:513:25: sparse: sparse: cast from restricted __be32
> drivers/spi/spi-nxp-fspi.c: note: in included file (through arch/sh/include/asm/io.h, include/linux/io.h, include/linux/irq.h, ...):
> >> include/asm-generic/io.h:1089:41: sparse: sparse: cast truncates bits from constant value (384000000506 becomes 506)
> --
> drivers/scsi/esas2r/esas2r_init.c:908:41: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned int [usertype] length @@ got restricted __le32 [usertype] @@
> drivers/scsi/esas2r/esas2r_init.c:908:41: sparse: expected unsigned int [usertype] length
> drivers/scsi/esas2r/esas2r_init.c:908:41: sparse: got restricted __le32 [usertype]
> drivers/scsi/esas2r/esas2r_init.c:1164:35: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned int [usertype] sgl_page_size @@ got restricted __le32 [usertype] @@
> drivers/scsi/esas2r/esas2r_init.c:1164:35: sparse: expected unsigned int [usertype] sgl_page_size
> drivers/scsi/esas2r/esas2r_init.c:1164:35: sparse: got restricted __le32 [usertype]
> drivers/scsi/esas2r/esas2r_init.c:1166:32: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned int [usertype] epoch_time @@ got restricted __le32 [usertype] @@
> drivers/scsi/esas2r/esas2r_init.c:1166:32: sparse: expected unsigned int [usertype] epoch_time
> drivers/scsi/esas2r/esas2r_init.c:1166:32: sparse: got restricted __le32 [usertype]
> drivers/scsi/esas2r/esas2r_init.c:1178:41: sparse: sparse: cast to restricted __le16
> drivers/scsi/esas2r/esas2r_init.c:1178:41: sparse: sparse: cast to restricted __le16
> drivers/scsi/esas2r/esas2r_init.c:1178:41: sparse: sparse: cast to restricted __le16
> drivers/scsi/esas2r/esas2r_init.c:1178:41: sparse: sparse: cast to restricted __le16
> drivers/scsi/esas2r/esas2r_init.c:1181:38: sparse: sparse: cast to restricted __le16
> drivers/scsi/esas2r/esas2r_init.c:1181:38: sparse: sparse: cast to restricted __le16
> drivers/scsi/esas2r/esas2r_init.c:1181:38: sparse: sparse: cast to restricted __le16
> drivers/scsi/esas2r/esas2r_init.c:1181:38: sparse: sparse: cast to restricted __le16
> drivers/scsi/esas2r/esas2r_init.c:1196:25: sparse: sparse: cast to restricted __be32
> drivers/scsi/esas2r/esas2r_init.c:1207:56: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned int [usertype] ctl_len @@ got restricted __le32 [usertype] @@
> drivers/scsi/esas2r/esas2r_init.c:1207:56: sparse: expected unsigned int [usertype] ctl_len
> drivers/scsi/esas2r/esas2r_init.c:1207:56: sparse: got restricted __le32 [usertype]
> drivers/scsi/esas2r/esas2r_init.c:1209:56: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned long long [usertype] address @@ got restricted __le64 [usertype] @@
> drivers/scsi/esas2r/esas2r_init.c:1209:56: sparse: expected unsigned long long [usertype] address
> drivers/scsi/esas2r/esas2r_init.c:1209:56: sparse: got restricted __le64 [usertype]
> drivers/scsi/esas2r/esas2r_init.c:1223:41: sparse: sparse: cast to restricted __le32
> drivers/scsi/esas2r/esas2r_init.c:1223:41: sparse: sparse: cast to restricted __le32
> drivers/scsi/esas2r/esas2r_init.c:1223:41: sparse: sparse: cast to restricted __le32
> drivers/scsi/esas2r/esas2r_init.c:1223:41: sparse: sparse: cast to restricted __le32
> drivers/scsi/esas2r/esas2r_init.c:1223:41: sparse: sparse: cast to restricted __le32
> drivers/scsi/esas2r/esas2r_init.c:1223:41: sparse: sparse: cast to restricted __le32
> drivers/scsi/esas2r/esas2r_init.c:1225:41: sparse: sparse: cast to restricted __le32
> drivers/scsi/esas2r/esas2r_init.c:1225:41: sparse: sparse: cast to restricted __le32
> drivers/scsi/esas2r/esas2r_init.c:1225:41: sparse: sparse: cast to restricted __le32
> drivers/scsi/esas2r/esas2r_init.c:1225:41: sparse: sparse: cast to restricted __le32
> drivers/scsi/esas2r/esas2r_init.c:1225:41: sparse: sparse: cast to restricted __le32
> drivers/scsi/esas2r/esas2r_init.c:1225:41: sparse: sparse: cast to restricted __le32
> drivers/scsi/esas2r/esas2r_init.c: note: in included file (through arch/sh/include/asm/io.h, include/linux/io.h, include/linux/irq.h, ...):
> >> include/asm-generic/io.h:1089:41: sparse: sparse: cast truncates bits from constant value (384000000506 becomes 506)
> >> include/asm-generic/io.h:1089:41: sparse: sparse: cast truncates bits from constant value (384000000506 becomes 506)
> drivers/scsi/esas2r/esas2r_init.c:286:15: sparse: sparse: memset with byte count of 557736
> drivers/scsi/esas2r/esas2r_init.c: note: in included file:
> drivers/scsi/esas2r/esas2r.h:1260:17: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned long long [usertype] ppsense_buf @@ got restricted __le64 [usertype] @@
> drivers/scsi/esas2r/esas2r.h:1260:17: sparse: expected unsigned long long [usertype] ppsense_buf
> drivers/scsi/esas2r/esas2r.h:1260:17: sparse: got restricted __le64 [usertype]
> drivers/scsi/esas2r/esas2r.h:1260:17: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned long long [usertype] ppsense_buf @@ got restricted __le64 [usertype] @@
> drivers/scsi/esas2r/esas2r.h:1260:17: sparse: expected unsigned long long [usertype] ppsense_buf
> drivers/scsi/esas2r/esas2r.h:1260:17: sparse: got restricted __le64 [usertype]
>
> vim +18 kernel/iomem.c
>
> 5981690ddb8f72 Dan Williams 2018-03-29 14
> 5981690ddb8f72 Dan Williams 2018-03-29 15 #ifndef arch_memremap_wb
> 5981690ddb8f72 Dan Williams 2018-03-29 16 static void *arch_memremap_wb(resource_size_t offset, unsigned long size)
> 5981690ddb8f72 Dan Williams 2018-03-29 17 {
> 5981690ddb8f72 Dan Williams 2018-03-29 @18 return (__force void *)ioremap_cache(offset, size);
> 5981690ddb8f72 Dan Williams 2018-03-29 19 }
> 5981690ddb8f72 Dan Williams 2018-03-29 20 #endif
> 5981690ddb8f72 Dan Williams 2018-03-29 21
>
> :::::: The code at line 18 was first introduced by commit
> :::::: 5981690ddb8f72f9546a2d017a914cf56095fc1f memremap: split devm_memremap_pages() and memremap() infrastructure
>
> :::::: TO: Dan Williams <dan.j.williams@xxxxxxxxx>
> :::::: CC: Dan Williams <dan.j.williams@xxxxxxxxx>
>
> --
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests/wiki
>

Next message: Hailong Liu: "Re: [RFC PATCH v2] mm/vmalloc: fix incorrect __vmap_pages_range_noflush() if vm_area_alloc_pages() from high order fallback to order0"
Previous message: Xiu Jianfeng: "Re: [PATCH v5 2/5] cgroup/pids: Make event counters hierarchical"
In reply to: kernel test robot: "kernel/iomem.c:18:32: sparse: sparse: cast truncates bits from constant value (38400000050e becomes 50e)"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]