Re: [PATCH] usb: gadget: f_fs: Define pr_fmt

From: Greg Kroah-Hartman
Date: Tue Jul 30 2024 - 01:00:44 EST


On Mon, Jul 29, 2024 at 03:53:50PM -0700, Bjorn Andersson wrote:
> The majority of log entries of f_fs are generated with no indication of
> their origin. Prefix these, using pr_fmt, to make the kernel log
> clearer.
>
> Signed-off-by: Bjorn Andersson <quic_bjorande@xxxxxxxxxxx>
> ---
> drivers/usb/gadget/function/f_fs.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/gadget/function/f_fs.c b/drivers/usb/gadget/function/f_fs.c
> index d8b096859337..14ee43cb27b6 100644
> --- a/drivers/usb/gadget/function/f_fs.c
> +++ b/drivers/usb/gadget/function/f_fs.c
> @@ -10,6 +10,7 @@
> * Copyright (C) 2003 Agilent Technologies
> */
>
> +#define pr_fmt(fmt) "f_fs: " fmt

Why not fix the driver up to use the proper dev_*() printing functions
instead?

Or, use KBUILD_MODNAME?

thanks,

greg k-h