Re: [PATCH v2 1/3] dt-bindings: net: bluetooth: Add support for Amlogic Bluetooth

[Yang Li]

On 2024/7/24 14:48, Yang Li wrote:
> On 2024/7/22 15:58, Krzysztof Kozlowski wrote:
> > On 22/07/2024 09:41, Yang Li wrote:
> > > > > > > +    description: bluetooth chip 3.3V supply regulator handle
> > > > > > > +
> > > > > > > +  clocks:
> > > > > > > +    maxItems: 1
> > > > > > > +    description: clock provided to the controller (32.768KHz)
> > > > > > > +
> > > > > > > +  antenna-number:
> > > > > > > +    default: 1
> > > > > > > +    description: device supports up to two antennas
> > > > > > Keep it consistent - either descriptions are the last property or
> > > > > > somewhere else. Usually the last.
> > > > > >
> > > > > > > +    $ref: /schemas/types.yaml#/definitions/uint32
> > > > > > And what does it mean? What happens if BT uses antenna number 2, 
> > > > > > not 1?
> > > > > > What is connected to the other antenna? It really feels useless 
> > > > > > to say
> > > > > > which antenna is connected to hardware.
> > > > > Sorry, the antenna description was incorrect, it should specify 
> > > > > whether
> > > > >
> > > > > Bluetooth and WiFi coexist. I will change it as below:
> > > > >
> > > > >        aml,work-mode:
> > > > >        type: boolean
> > > > >        description: specifywhether Bluetooth and WiFi coexist.
> > > > So one device can be used on different boards - some without WiFi
> > > > antenna? But, why in the binding of bluetooth you describe whether 
> > > > there
> > > > is WiFi antenna?
> > > Yes, it can be used on dirfferent boards. The device can operate in 
> > > both
> > Please do not respond to only partial part of the comment. It is obvious
> > device can work on different boards. You do not have to confirm it. The
> > question was different - why do you need this property? I gave you
> > possible answer, but you skipped this and answered with obvious 
> > statement.
>
> I'm sorry. I didn't explain it clearly.
>
> Board design should be optimized for specific use cases: use the 
> standalone mode for high-speed, stable, and Bluetooth-only 
> applications; opt for the coexistence mode in cost-sensitive scenarios 
> with lower performance demands. Once the hardware is determined, the 
> user needs to configure the working mode of the firmware.
>
> > > standalone mode and coexistence mode. typically running standalone 
> > > mode.
> > >
> > > Therefore, I would like to revise the description as follows:
> > >
> > > aml,coexisting:
> > >       type: boolean
> > >       description: Enable coexistence mode, allowing shared antenna 
> > > usage
> > > with Wi-Fi.
> > Why this is not enabled always?
>
> The board design determines whether to enable this property.
>
> Well, I know I should clearly describe why this property is enabled 
> here, so I modify it as follows:
>
> aml,coexisting:
>      type: boolean
>      description: Enable co-existence mode on boards sharing antennas 
> with Wi-Fi.
Hi Krzysztof
After internal discussions, we determined that Bluetooth Controllers 
typically operate in standalone mode and are only configured for sharing 
upon customer-specific customization. Consequently, we have decided to 
remove this property. Please be advised that the third patch will be 
updated accordingly at a later date
> > Best regards,
> > Krzysztof