Re: [PATCH] usb: storage: ene_ub6250: Fix right shift warnings

From: Oliver Neukum
Date: Tue Jul 30 2024 - 03:09:20 EST




On 29.07.24 20:23, Abhishek Tamboli wrote:
Change bl_len from u16 to u32 to accommodate the necessary bit shifts.

Hi,

while this patch is technically correct, it papers over the issue.
Could you please

1. use a constant, where a constant is used
2. use the macros for converting endianness

Regards
Oliver