Re: [PATCH 1/1] arm64: dts: imx8-ss-dma: enable dma support for lpspi

[Alexander Stein]

Hi Krzysztof,

Am Montag, 29. Juli 2024, 17:10:48 CEST schrieb Krzysztof Kozlowski:
> On 29/07/2024 11:45, Alexander Stein wrote:
> > From: Clark Wang <xiaoning.wang@xxxxxxx>
> > 
> > Add DMA configurations for LPSPI nodes on i.MX8QX/QM/DXL.
> > 
> > Signed-off-by: Clark Wang <xiaoning.wang@xxxxxxx>
> > Signed-off-by: Alexander Stein <alexander.stein@xxxxxxxxxxxxxxx>
> > ---
> > Using the DMA configuration bits from downstream kernel.
> > Tested on TQMa8XxS.
> > 
> >  arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi | 8 ++++++++
> >  1 file changed, 8 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi b/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi
> > index 1ee9496c988c5..8ae5f065b4180 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi
> > @@ -34,6 +34,8 @@ lpspi0: spi@5a000000 {
> >  		assigned-clocks = <&clk IMX_SC_R_SPI_0 IMX_SC_PM_CLK_PER>;
> >  		assigned-clock-rates = <60000000>;
> >  		power-domains = <&pd IMX_SC_R_SPI_0>;
> > +		dma-names = "tx","rx";
> 
> Missing spaces. Unexpected order, unless that's the coding style for imx.

Ack for the space, will correct. But the order is defined that way in
Documentation/devicetree/bindings/spi/spi-fsl-lpspi.yaml

Best regards,
Alexander
-- 
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/