Re: [PATCH net-next v17 03/14] netdev: support binding dma-buf to netdevice

From: Markus Elfring
Date: Tue Jul 30 2024 - 04:39:51 EST

Next message: kernel test robot: "[tip:irq/urgent] BUILD SUCCESS f872d4af79fe8c71ae291ce8875b477e1669a6c7"
Previous message: Daniel Vetter: "Re: [PATCH] drm: Add the missing symbol '.'"
In reply to: Mina Almasry: "[PATCH net-next v17 03/14] netdev: support binding dma-buf to netdevice"
Next in thread: Mina Almasry: "[PATCH net-next v17 05/14] page_pool: move dmaddr helpers to .c file"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

…
> +++ b/include/net/devmem.h
> @@ -0,0 +1,115 @@
…
> +#ifndef _NET_DEVMEM_H
> +#define _NET_DEVMEM_H
…

I suggest to omit leading underscores from such identifiers.
https://wiki.sei.cmu.edu/confluence/display/c/DCL37-C.+Do+not+declare+or+define+a+reserved+identifier

Regards,
Markus

Next message: kernel test robot: "[tip:irq/urgent] BUILD SUCCESS f872d4af79fe8c71ae291ce8875b477e1669a6c7"
Previous message: Daniel Vetter: "Re: [PATCH] drm: Add the missing symbol '.'"
In reply to: Mina Almasry: "[PATCH net-next v17 03/14] netdev: support binding dma-buf to netdevice"
Next in thread: Mina Almasry: "[PATCH net-next v17 05/14] page_pool: move dmaddr helpers to .c file"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]