Re: [PATCH 11/11] arm64: dts: qcom: sm7325: Add device-tree for Nothing Phone 1

[Krzysztof Kozlowski]

On 29/07/2024 22:18, Danila Tikhonov wrote:
> From: Eugene Lepshy <fekz115@xxxxxxxxx>
> 
> Add device tree for the Nothing Phone 1 (nothing,spacewar) smartphone
> which is based on the SM7325 SoC.

...

> +
> +&i2c2 {
> +	clock-frequency = <100000>;
> +	status = "okay";
> +
> +	/* nxp,tfa9873 (EAR speaker codec) @ 34 */
> +	/* nxp,tfa9873 (Main speaker codec) @ 35 */
> +};
> +
> +&i2c9 {
> +	clock-frequency = <1000000>;
> +	status = "okay";
> +
> +	nfc@28 {
> +		compatible = "nxp,nxp-nci-i2c";

Prepend it with proper compatible for this NFC chip and update the bindings.

> +		reg = <0x28>;
> +
> +		interrupt-parent = <&tlmm>;
> +		interrupts = <41 IRQ_TYPE_NONE>;

This does not look like valid interrupt type...



Best regards,
Krzysztof