Re: Re: [PATCH] sched/fair: Correct CPU selection from isolated domain

From: Greg KH
Date: Tue Jul 30 2024 - 05:11:56 EST


On Tue, Jul 30, 2024 at 05:03:38PM +0800, wujing wrote:
> > If you're trying to backport something, I think you forgot to Cc stable
> > and provide the proper upstream commit.
> >
> > As is this isn't something I can do anything with. The patch does not
> > apply to any recent kernel and AFAICT this issue has long since been
> > fixed.
>
> When fixing this bug, I didn't pay much attention to upstream changes.
> Upon reviewing the history of relevant commits, I found that they have
> been merged and reverted multiple times:
>
> ```bash
> git log -S 'cpumask_test_cpu(cpu, sched_domain_span(sd))' --oneline \
> kernel/sched/fair.c
>
> 8aeaffef8c6e sched/fair: Take the scheduling domain into account in select_idle_smt()
> 3e6efe87cd5c sched/fair: Remove redundant check in select_idle_smt()
> 3e8c6c9aac42 sched/fair: Remove task_util from effective utilization in feec()
> c722f35b513f sched/fair: Bring back select_idle_smt(), but differently
> 6cd56ef1df39 sched/fair: Remove select_idle_smt()
> df3cb4ea1fb6 sched/fair: Fix wrong cpu selecting from isolated domain
> ```
>
> The latest upstream commit 8aeaffef8c6e is not applicable to linux-4.19.y.
> The current patch has been tested on linux-4.19.y and I am looking forward
> to its inclusion in the stable version.

What "current patch"?

confused,

greg k-h