Re: [PATCH v2] char: misc: add missing #ifdef CONFIG_PROC_FS

From: Greg KH
Date: Tue Jul 30 2024 - 05:12:46 EST


On Tue, Jul 30, 2024 at 04:31:58PM +0800, zhangjiao2 wrote:
> From: Zhang Jiao <zhangjiao2@xxxxxxxxxxxxxxxxxxxx>
>
> Since misc_seq_ops is defined under CONFIG_PROC_FS in this file,
> it also need under CONFIG_PROC_FS when use.
>
> >Again, why is a #ifdef ok in this .c file? What changed to suddenly
> >require this?
> There is another #ifdef in this file, in there "misc_seq_ops" is defined.
> If CONFIG_PROC_FS is not defined, proc_create_seq is using an
> undefined variable "misc_seq_ops", this may cause compile error.
>

Why is this in the changelog text?

And what changed to suddenly require this proposed patch? What commit
id does it fix?

confused,

greg k-h