Re: [PATCH 14/36] soc: fsl: cpm1: tsa: Add support for QUICC Engine (QE) implementation

From: Markus Elfring
Date: Tue Jul 30 2024 - 05:26:06 EST



> +++ b/drivers/soc/fsl/qe/tsa.c

> +static int tsa_qe_serial_connect(struct tsa_serial *tsa_serial, bool connect)
> +{

> + spin_lock_irqsave(&tsa->lock, flags);
> + ret = ucc_set_qe_mux_tsa(ucc_num, connect);
> + spin_unlock_irqrestore(&tsa->lock, flags);


Under which circumstances would you become interested to apply a statement
like “guard(spinlock_irqsave)(&tsa->lock);”?
https://elixir.bootlin.com/linux/v6.11-rc1/source/include/linux/spinlock.h#L572

Regards,
Markus