Re: [EXTERNAL] Re: [PATCH v11 4/9] spi: cadence: Add Marvell SDMA operations

[Geert Uytterhoeven]

Hi Witold,

On Tue, Jul 30, 2024 at 12:06 PM Witold Sadowski <wsadowski@xxxxxxxxxxx> wrote:
> > drivers/spi/spi-cadence-xspi.c:612:33: error: implicit declaration of
> > function 'readq'; did you mean 'readb'?
> > [-Werror=implicit-function-declaration]
> > drivers/spi/spi-cadence-xspi.c:638:25: error: implicit declaration of
> > function 'writeq'; did you mean 'writel'?
> > [-Werror=implicit-function-declaration]
> >
> >
> > readq() and writeq() are not available on 32-bit platforms, so this
> > driver has to
> > depend on 64BIT (for compile-testing).
> >
> > > +                       *buffer++ = b;
> > > +               } while (--full_ops);
> > > +       }
>
> How can I limit that driver for 64bit test only?

drivers/spi/Kconfig, config SPI_CADENCE_XSPI:

  -depends on OF && HAS_IOMEM
  +depends on OF && HAS_IOMEM && 64BIT

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds