Re: [PATCH net-next] net: wangxun: use net_prefetch to simplify logic

[Wojciech Drewek]

On 29.07.2024 17:26, Joe Damato wrote:
> Use net_prefetch to remove #ifdef and simplify prefetch logic. This
> follows the pattern introduced in a previous commit f468f21b7af0 ("net:
> Take common prefetch code structure into a function"), which replaced
> the same logic in all existing drivers at that time.
> 
> Signed-off-by: Joe Damato <jdamato@xxxxxxxxxx>
> ---

Reviewed-by: Wojciech Drewek <wojciech.drewek@xxxxxxxxx>

>  drivers/net/ethernet/wangxun/libwx/wx_lib.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/net/ethernet/wangxun/libwx/wx_lib.c b/drivers/net/ethernet/wangxun/libwx/wx_lib.c
> index 1eecba984f3b..2b3d6586f44a 100644
> --- a/drivers/net/ethernet/wangxun/libwx/wx_lib.c
> +++ b/drivers/net/ethernet/wangxun/libwx/wx_lib.c
> @@ -251,10 +251,7 @@ static struct sk_buff *wx_build_skb(struct wx_ring *rx_ring,
>  				  rx_buffer->page_offset;
>  
>  		/* prefetch first cache line of first page */
> -		prefetch(page_addr);
> -#if L1_CACHE_BYTES < 128
> -		prefetch(page_addr + L1_CACHE_BYTES);
> -#endif
> +		net_prefetch(page_addr);
>  
>  		/* allocate a skb to store the frags */
>  		skb = napi_alloc_skb(&rx_ring->q_vector->napi, WX_RXBUFFER_256);