Re: [PATCH net v2] net: ethernet: mtk_eth_soc: drop clocks unused by Ethernet driver

From: Paolo Abeni
Date: Tue Jul 30 2024 - 06:41:12 EST




On 7/30/24 12:22, Daniel Golle wrote:
On Tue, Jul 30, 2024 at 10:53:19AM +0200, Paolo Abeni wrote:
On 7/30/24 04:06, Jakub Kicinski wrote:
On Mon, 29 Jul 2024 00:00:23 +0100 Daniel Golle wrote:
Clocks for SerDes and PHY are going to be handled by standalone drivers
for each of those hardware components. Drop them from the Ethernet driver.

The clocks which are being removed for this patch are responsible for
the for the SerDes PCS and PHYs used for the 2nd and 3rd MAC which are
anyway not yet supported. Hence backwards compatibility is not an issue.

What user visible issue is it fixing, then?

Indeed this looks like more a cleanup than a fix. @Daniel why net-next
without fixes tag is not a suitable target here?

There is no user visible issue. I didn't know that this would be the
condition for going into 'net'. I will resend the patch to net-next.

See:

https://elixir.bootlin.com/linux/v6.10.2/source/Documentation/process/maintainer-netdev.rst#L68

The main point here is the patch looks more a cleanup than a fix.

If so, please also drop the fixes tag when re-posting, thanks!

Paolo