Re: [PATCH] x86/sev: Fix __reserved field in sev_config

[Tom Lendacky]

On 7/29/24 13:08, Pavan Kumar Paluri wrote:
> sev_config currently has debug, ghcbs_initialized, and use_cas fields.
> However, __reserved count has not been updated. Fix this.
> 
> Fixes: 34ff65901735 ("x86/sev: Use kernel provided SVSM Calling Areas")
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Pavan Kumar Paluri <papaluri@xxxxxxx>

Reviewed-by: Tom Lendacky <thomas.lendacky@xxxxxxx>

You'd think the compiler would spit out some kind of warning when this
happens, but I guess it just happily adds another u64 to the struct.

Thanks,
Tom

> ---
>  arch/x86/coco/sev/core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/coco/sev/core.c b/arch/x86/coco/sev/core.c
> index 082d61d85dfc..de1df0cb45da 100644
> --- a/arch/x86/coco/sev/core.c
> +++ b/arch/x86/coco/sev/core.c
> @@ -163,7 +163,7 @@ struct sev_config {
>  	       */
>  	      use_cas		: 1,
>  
> -	      __reserved	: 62;
> +	      __reserved	: 61;
>  };
>  
>  static struct sev_config sev_cfg __read_mostly;