Re: [PATCH 6/7] jbd2: correct comment jbd2_mark_journal_empty

[Jan Kara]

On Tue 30-07-24 19:33:34, Kemeng Shi wrote:
> After jbd2_mark_journal_empty, journal log is supposed to be empty.
> 
> Signed-off-by: Kemeng Shi <shikemeng@xxxxxxxxxxxxxxx>

Looks good. Feel free to add:

Reviewed-by: Jan Kara <jack@xxxxxxx>

							Honza

> ---
>  fs/jbd2/journal.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/jbd2/journal.c b/fs/jbd2/journal.c
> index f17d05bc61df..dc18b9f7c999 100644
> --- a/fs/jbd2/journal.c
> +++ b/fs/jbd2/journal.c
> @@ -1939,7 +1939,7 @@ static void jbd2_mark_journal_empty(journal_t *journal, blk_opf_t write_flags)
>  	if (had_fast_commit)
>  		jbd2_set_feature_fast_commit(journal);
>  
> -	/* Log is no longer empty */
> +	/* Log is empty */
>  	write_lock(&journal->j_state_lock);
>  	journal->j_flags |= JBD2_FLUSHED;
>  	write_unlock(&journal->j_state_lock);
> -- 
> 2.30.0
> 
-- 
Jan Kara <jack@xxxxxxxx>
SUSE Labs, CR