RE: [EXTERNAL] Re: [PATCH v1] ASoc: tas2781: Move tas2563_dvc_table into a separate Header file
From: Ding, Shenghao
Date: Tue Jul 30 2024 - 10:18:00 EST
Hi Broonie
> -----Original Message-----
> From: Mark Brown <broonie@xxxxxxxxxx>
> Sent: Tuesday, July 30, 2024 8:27 PM
> To: Ding, Shenghao <shenghao-ding@xxxxxx>
> Cc: andriy.shevchenko@xxxxxxxxxxxxxxx; lgirdwood@xxxxxxxxx;
> perex@xxxxxxxx; pierre-louis.bossart@xxxxxxxxxxxxxxx;
> 13916275206@xxxxxxx; zhourui@xxxxxxxxxx; alsa-devel@xxxxxxxxxxxxxxxx;
> Salazar, Ivan <i-salazar@xxxxxx>; linux-kernel@xxxxxxxxxxxxxxx; Chadha, Jasjot
> Singh <j-chadha@xxxxxx>; liam.r.girdwood@xxxxxxxxx; Yue, Jaden <jaden-
> yue@xxxxxx>; yung-chuan.liao@xxxxxxxxxxxxxxx; Rao, Dipa <dipa@xxxxxx>;
> yuhsuan@xxxxxxxxxx; Lo, Henry <henry.lo@xxxxxx>; tiwai@xxxxxxx; Xu,
> Baojun <baojun.xu@xxxxxx>; soyer@xxxxxx; Baojun.Xu@xxxxxxx;
> judyhsiao@xxxxxxxxxx; Navada Kanyana, Mukund <navada@xxxxxx>;
> cujomalainey@xxxxxxxxxx; Kutty, Aanya <aanya@xxxxxx>; Mahmud, Nayeem
> <nayeem.mahmud@xxxxxx>; savyasanchi.shukla@xxxxxxxxxxxxx;
> flaviopr@xxxxxxxxxxxxx; Ji, Jesse <jesse-ji@xxxxxx>; darren.ye@xxxxxxxxxxxx;
> antheas.dk@xxxxxxxxx
> Subject: Re: [EXTERNAL] Re: [PATCH v1] ASoc: tas2781: Move
> tas2563_dvc_table into a separate Header file
>
> On Tue, Jul 30, 2024 at 01:24:34AM +0000, Ding, Shenghao wrote:
>
> > One more thing, these day my colleague and I want have some adjustment
> > on the
> > tas2781 driver code to support both i2c and spi interface, and plan to
> > abstract the common part, especially the dsp binary parsing, as a
> > shared lib. Would you be so kind and give us some advice on it? Thanks.
>
> That seems like a sensible and reasonable design - factoring out common code
> is a good idea, there's a number of existing drivers doing things ike that.
> Possibly the biggest example is the Cirrus/Wolfson Arizona drivers and the
> wm_adsp DSPs they use. Do you have specific questions around this?
Thanks for your advice. So far, I have no specific questions. First, I will study
Cirrus/Wolfson Arizona drivers and then find a suitable solution for tas2563/tas2781.