Re: [PATCH v6 4/5] media: platform: mediatek: isp_30: add mediatek ISP3.0 camsv

From: Markus Elfring
Date: Tue Jul 30 2024 - 11:01:10 EST



> +++ b/drivers/media/platform/mediatek/isp/isp_30/camsv/mtk_camsv30_hw.c
> @@ -0,0 +1,413 @@

> +static int mtk_camsv30_runtime_resume(struct device *dev)
> +{

> + mtk_camsv30_setup(cam_dev, fmt->width, fmt->height,
> + fmt->plane_fmt[0].bytesperline, vdev->fmtinfo->code);
> +
> + spin_lock_irqsave(&cam_dev->buf_list_lock, flags);

> + mtk_camsv30_cmos_vf_hw_enable(cam_dev);
> +
> + spin_unlock_irqrestore(&cam_dev->buf_list_lock, flags);


Under which circumstances would you become interested to apply a statement
like “guard(spinlock_irqsave)(&cam_dev->buf_list_lock);”?
https://elixir.bootlin.com/linux/v6.11-rc1/source/include/linux/spinlock.h#L572

Regards,
Markus