Re: [PATCH] dt-bindings: clock: nxp,lpc3220-clk: Convert bindings to DT schema

[Krzysztof Kozlowski]

On 29/07/2024 21:37, Animesh Agarwal wrote:
> Convert the NXP LPC32xx Clock Controller bindings to yaml format.
> 
> Cc: Daniel Baluta <daniel.baluta@xxxxxxx>
> Signed-off-by: Animesh Agarwal <animeshagarwal28@xxxxxxxxx>

> +
> +properties:
> +  compatible:
> +    const: nxp,lpc3220-clk
> +
> +  reg:
> +    maxItems: 1
> +
> +  '#clock-cells':
> +    const: 1
> +
> +  clocks:
> +    description: Phandles of external oscillators, the list must contain one
> +      32768 Hz oscillator and may have one optional high frequency oscillator.
> +    maxItems: 2

That's not correct and does not match clock-names. List the items with
description instead of above "phandles ...." and add minItems.


> +
> +  clock-names:
> +    oneOf:

Drop. It's:

minItems: 1
items:
 - const: ...
 - const:

> +      - items:
> +          - const: xtal_32k
> +          - const: xtal
> +      - const: xtal_32k
> +


Best regards,
Krzysztof