Re: [PATCH can-next 11/21] can: rockchip_canfd: add functions to check if CAN-FD frames are equal

From: Simon Horman
Date: Tue Jul 30 2024 - 12:38:03 EST


On Mon, Jul 29, 2024 at 03:05:42PM +0200, Marc Kleine-Budde wrote:
> Add a pair new functions to check if 2 struct canfd_frame are equal.
> The 1st checks if the header of the CAN frames are equal, the 2nd
> checks if the data portion are equal:
>
> - rkcanfd_can_frame_header_equal()
> - rkcanfd_can_frame_data_equal()
>
> This functionality is needed in the next patch.

nit: I would squash this into the next patch as
rkcanfd_can_frame_header_equal() is defined but
unused in this patch, which is flagged by
allmodconfig W=1 builds.

...