Re: [PATCH bpf-next v3 1/3] selftests/bpf: do not disable /dev/null device access in cgroup dev test

From: Alan Maguire
Date: Tue Jul 30 2024 - 13:34:13 EST


On 30/07/2024 12:59, Alexis Lothoré (eBPF Foundation) wrote:
> test_dev_cgroup currently loads a small bpf program allowing any access on
> urandom and zero devices, disabling access to any other device. It makes
> migrating this test to test_progs impossible, since this one manipulates
> extensively /dev/null.
>
> Allow /dev/null manipulation in dev_cgroup program to make its usage in
> test_progs framework possible. Update test_dev_cgroup.c as well to match
> this change while it has not been removed.
>
> Signed-off-by: Alexis Lothoré (eBPF Foundation) <alexis.lothore@xxxxxxxxxxx>

Reviewed-by: Alan Maguire <alan.maguire@xxxxxxxxxx>

> ---
> tools/testing/selftests/bpf/progs/dev_cgroup.c | 4 ++--
> tools/testing/selftests/bpf/test_dev_cgroup.c | 18 +++++++++---------
> 2 files changed, 11 insertions(+), 11 deletions(-)