Re: [PATCH v1 1/1] mfd: rk8xx: Fix shutdown handler

[Urja]

Hi,

On Tuesday, 30 July 2024 at 9:05 PM, Sebastian Reichel <sebastian.reichel@xxxxxxxxxxxxx> wrote:

> To avoid this we keep the SYS_OFF_MODE_POWER_OFF_PREPARE handler for the
> SPI backend. This is not great, but at least avoids regressions and the
> fix should be small enough to allow backporting.
> 
> As a side-effect this also works around a shutdown problem on the Asus
> C201. For reasons unknown that skips calling the prepare handler and
> directly calls the final shutdown handler.

I can clarify that bit a little - basically, when the handler is registered
as a poweroff prepare handler, the kernel thinks that the C201 cannot poweroff
and converts the poweroff into a halt, so I assume the
power_off_handler_list is empty - which makes sense, the C201 has no firmware
to call or other poweroff methods that I'd be aware of.
(See kernel/reboot.c line 746 and 683.) 

Anyways, this patch works on the C201 (tested on top of 6.11-rc1).
Tested-by: Urja <urja@xxxxxxxx>

Thank you
--
Urja Rannikko