Re: [PATCH 3/5] serial: 8250: omap: Set wakeup capable, do not enable

From: Kevin Hilman
Date: Tue Jul 30 2024 - 15:34:09 EST


Markus Schneider-Pargmann <msp@xxxxxxxxxxxx> writes:

> The driver sets wakeup enable by default. But not all uarts are meant to
> be wakeup enabled. Change the default to be wakeup capable but not
> enabled. The user can enable wakeup when needed.
>
> Signed-off-by: Markus Schneider-Pargmann <msp@xxxxxxxxxxxx>

Acked-by: Kevin Hilman <khilman@xxxxxxxxxxxx>

> ---
> drivers/tty/serial/8250/8250_omap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/8250/8250_omap.c b/drivers/tty/serial/8250/8250_omap.c
> index ca456ea23317..5b7508dfb5d8 100644
> --- a/drivers/tty/serial/8250/8250_omap.c
> +++ b/drivers/tty/serial/8250/8250_omap.c
> @@ -1496,7 +1496,7 @@ static int omap8250_probe(struct platform_device *pdev)
>
> platform_set_drvdata(pdev, priv);
>
> - device_init_wakeup(&pdev->dev, true);
> + device_set_wakeup_capable(&pdev->dev, true);
> pm_runtime_enable(&pdev->dev);
> pm_runtime_use_autosuspend(&pdev->dev);
>
> --
> 2.43.0