Re: [PATCH] rust: support arrays in target JSON

From: Gatlin Newhouse
Date: Tue Jul 30 2024 - 18:33:13 EST


On Tue, Jul 30, 2024 at 10:56:46AM UTC, Gary Guo wrote:
> On Tue, 30 Jul 2024 09:26:24 +0000
> Alice Ryhl <aliceryhl@xxxxxxxxxx> wrote:
>
> > From: Matthew Maurer <mmaurer@xxxxxxxxxx>
> >
> > Some configuration options such as the supported sanitizer list are
> > arrays. To support using Rust with sanitizers on x86, we must update the
> > target.json generator to support this case.
> >
> > The Push trait is removed in favor of the From trait because the Push
> > trait doesn't work well in the nested case where you are not really
> > pushing values to a TargetSpec.
> >
> > Signed-off-by: Matthew Maurer <mmaurer@xxxxxxxxxx>
> > Signed-off-by: Alice Ryhl <aliceryhl@xxxxxxxxxx>
>
> Reviewed-by: Gary Guo <gary@xxxxxxxxxxx>

Tested-by: Gatlin Newhouse <gatlin.newhouse@xxxxxxxxx>

> > ---
> > scripts/generate_rust_target.rs | 82 +++++++++++++++++++++------------
> > 1 file changed, 53 insertions(+), 29 deletions(-)