Re: [PATCH v6 0/5] x86/pkeys: update PKRU to enable pkey 0 before

[Aruna Ramakrishna]

> On Jul 16, 2024, at 9:25 PM, Jeff Xu <jeffxu@xxxxxxxxxxxx> wrote:
> 
> Hi Aruna,
> 
> I added Rick who commented on the previous version of patch. I added
> Kees/Jorge/Stephan/Yann,  they expressed interest in similar
> functionality before. It would be best to keep them in future versions
> of this patch.
> 
> I also add linux-mm for more reviews/feedback on signal handling path.
> 
> On Thu, Jun 27, 2024 at 2:17 PM Aruna Ramakrishna
> <aruna.ramakrishna@xxxxxxxxxx> wrote:
>> 
>> v6 updates:
>> - Rebased patchset to v6.10.0-rc5
>> - Changed sig_prepare_pkru() back to enabling all pkeys, based on
>> discussion with Jeff Xu
> Thanks for taking the suggestion.
> 
>> 
>> As Jeff mentioned, I'm unsure if we need to retain the changes to the
>> 32-bit functions. Maintainers - please advise.
>> 
> It is possible to  reduce the size of change.
> Not touching the ia32 or x32 code path also means less test in
> multiple architectures and less risk of regression.

Apologies for the delay in responding - I was on vacation and got back
yesterday.

I agree, I’m unsure if 32-bit support is needed here - as you pointed out in an
earlier email, the man page says:
“The feature is only available in 64-bit mode, even though there is theoretically
space in the PAE PTEs.”

I was hoping that Dave/Thomas would review and clarify. I will remove the
32-bit support from this patchset and send out a v7.

Thanks,
Aruna