Re: [PATCH net v2] net/tcp: Disable TCP-AO static key after RCU grace period

[Dmitry Safonov]

On Wed, 31 Jul 2024 at 02:37, Jakub Kicinski <kuba@xxxxxxxxxx> wrote:
>
> On Tue, 30 Jul 2024 01:33:17 +0100 Dmitry Safonov via B4 Relay wrote:
> > +     struct hlist_node *n;
> > +
> > +     hlist_for_each_entry_safe(key, n, &ao->head, node)
> > +             total_ao_sk_mem += tcp_ao_sizeof_key(key);
>
> nit:
>
> s/_safe//
>
> no need to safely iterate if we're not modifying the list

Certainly! The keys can't be deleted by another CPU once it's
tcp_ao_destroy_sock(), somehow haven't thought about the iterator
here.
Will send v3.

Thanks,
             Dmitry