Re: [PATCH] x86/cpufeatures: SGX: Adjust the error message when BIOS does not support SGX

From: WangYuli
Date: Tue Jul 30 2024 - 23:23:25 EST


On 2024/7/30 19:57, Huang, Kai wrote:

+linux-sgx list, Jarkko, Haitao.

This message is only printed when SGX is reported in CPUID but is not
enabled in the FEAT_CTL MSR. I can only recall this can happen when the
BIOS actually provides an option for the user to turn on/off SGX, in
which case the current message is correct.

I could be wrong, but I don't recall I have met any machine that doesn't
have any SGX option in the BIOS but still reports SGX in the CPUID. Can
you confirm this is the case?

Sure.

For example, Lenovo ThinkPad T480s that compliance id is TP00092A.


I don't see this is mentioned in the github link below which reports this
issue. In fact, it says:

非bug,主板bios关闭了SGX,正常内核提醒

.. which is

Not bug, the motherboard BIOS disabled SGX, normal kernel
message
hah, that's a typo.

And the link also shows this issue is "closed".

Please clarify.
--
WangYuli