Re: [PATCH v2] staging: rtl8723bs: Improve MAR register definition and usage

[Philipp Hortmann]

On 7/31/24 01:10, Manjae Cho wrote:
> This patch improves the usage of the MAR register by updating the relevant
> macro definitions and ensuring consistent usage across the codebase.
>
> Signed-off-by: Manjae Cho <manjae.cho@xxxxxxxxxxx>
> ---
> v2: Fix line length
>
>   drivers/staging/rtl8723bs/include/hal_com_reg.h | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/include/hal_com_reg.h b/drivers/staging/rtl8723bs/include/hal_com_reg.h
> index baf326d53a46..93aa391fa749 100644
> --- a/drivers/staging/rtl8723bs/include/hal_com_reg.h
> +++ b/drivers/staging/rtl8723bs/include/hal_com_reg.h
> @@ -151,8 +151,8 @@
>   #define REG_BSSID						0x0618
>   #define REG_MAR							0x0620
>   
> -#define MAR0						REG_MAR		/* Multicast Address Register, Offset 0x0620-0x0623 */
> -#define MAR4						(REG_MAR + 4)	/* Multicast Address Register, Offset 0x0624-0x0627 */
> +#define MAR0		REG_MAR		/* Multicast Address Register, Offset 0x0620-0x0623 */
> +#define MAR4		(REG_MAR + 4)	/* Multicast Address Register, Offset 0x0624-0x0627 */
>   
>   #define REG_MAC_SPEC_SIFS				0x063A
>   /*  20100719 Joseph: Hardware register definition change. (HW datasheet v54) */

Hi Manjae,

this patch cannot be applied because you build it on top of your first 
patch which was not accepted. Please rebase this patch.

Thanks for your support.

Bye Philipp