Re: [PATCH net-next v5 13/14] microchip: lan865x: add driver support for Microchip's LAN865X MAC-PHY

[Parthiban.Veerasooran]

Hi Randy,

On 30/07/24 9:45 am, Randy Dunlap wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> On 7/29/24 9:09 PM, Parthiban Veerasooran wrote:
>> The LAN8650/1 is designed to conform to the OPEN Alliance 10BASE-T1x
>> MAC-PHY Serial Interface specification, Version 1.1. The IEEE Clause 4
>> MAC integration provides the low pin count standard SPI interface to any
>> microcontroller therefore providing Ethernet functionality without
>> requiring MAC integration within the microcontroller. The LAN8650/1
>> operates as an SPI client supporting SCLK clock rates up to a maximum of
>> 25 MHz. This SPI interface supports the transfer of both data (Ethernet
>> frames) and control (register access).
>>
>> By default, the chunk data payload is 64 bytes in size. The Ethernet
>> Media Access Controller (MAC) module implements a 10 Mbps half duplex
>> Ethernet MAC, compatible with the IEEE 802.3 standard. 10BASE-T1S
>> physical layer transceiver integrated is into the LAN8650/1. The PHY and
>> MAC are connected via an internal Media Independent Interface (MII).
>>
>> Signed-off-by: Parthiban Veerasooran <Parthiban.Veerasooran@xxxxxxxxxxxxx>
>> ---
>>   MAINTAINERS                                   |   6 +
>>   drivers/net/ethernet/microchip/Kconfig        |   1 +
>>   drivers/net/ethernet/microchip/Makefile       |   1 +
>>   .../net/ethernet/microchip/lan865x/Kconfig    |  19 +
>>   .../net/ethernet/microchip/lan865x/Makefile   |   6 +
>>   .../net/ethernet/microchip/lan865x/lan865x.c  | 391 ++++++++++++++++++
>>   6 files changed, 424 insertions(+)
>>   create mode 100644 drivers/net/ethernet/microchip/lan865x/Kconfig
>>   create mode 100644 drivers/net/ethernet/microchip/lan865x/Makefile
>>   create mode 100644 drivers/net/ethernet/microchip/lan865x/lan865x.c
>>
> 
>> diff --git a/drivers/net/ethernet/microchip/lan865x/Kconfig b/drivers/net/ethernet/microchip/lan865x/Kconfig
>> new file mode 100644
>> index 000000000000..f3d60d14e202
>> --- /dev/null
>> +++ b/drivers/net/ethernet/microchip/lan865x/Kconfig
>> @@ -0,0 +1,19 @@
>> +# SPDX-License-Identifier: GPL-2.0-only
>> +#
>> +# Microchip LAN865x Driver Support
>> +#
>> +
>> +if NET_VENDOR_MICROCHIP
>> +
>> +config LAN865X
>> +     tristate "LAN865x support"
>> +     depends on SPI
>> +     depends on OA_TC6
> 
> Since OA_TC6 is described as a library, it would make sense to select OA_TC6 here instead
> of depending on it.
> OTOH, that might cause some Kconfig dependency issues... I haven't looked into that.Yes that makes sense. I will change it in the next version.

Best regards,
Parthiban V
> 
>> +     help
>> +       Support for the Microchip LAN8650/1 Rev.B1 MACPHY Ethernet chip. It
>> +       uses OPEN Alliance 10BASE-T1x Serial Interface specification.
>> +
>> +       To compile this driver as a module, choose M here. The module will be
>> +       called lan865x.
>> +
>> +endif # NET_VENDOR_MICROCHIP
> 
> 
> --
> ~Randy