Re: [PATCH 1/1] dt-bindings: usb: microchip, usb2514: Add USB2517 compatible

[Krzysztof Kozlowski]

On 31/07/2024 09:34, Alexander Stein wrote:
> Am Mittwoch, 31. Juli 2024, 09:32:43 CEST schrieb Krzysztof Kozlowski:
>> On 31/07/2024 09:27, Krzysztof Kozlowski wrote:
>>> On 31/07/2024 09:19, Alexander Stein wrote:
>>>> USB2517 is a 7-port variant of this USB hub. Add an USB compatible
>>>> based on USB vendor & product ID.
>>>>
>>>> Signed-off-by: Alexander Stein <alexander.stein@xxxxxxxxxxxxxxx>
>>>
>>> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
>>
>> Of course assuming there is some user? If so, where?
> 
> There is: arch/arm64/boot/dts/freescale/imx93-tqma9352-mba93xxla.dts
> introduced by commit ba9943f47dca1 ("arm64: dts: mba93xxla: Add USB support")

Bindings 1.5 years after you added compatible... checkpatch told you
that you miss bindings that time.

This should be explained in commit msg - you add compatible for a
compatible already present in the kernel.

Best regards,
Krzysztof