Re: [PATCH v2 1/2] arm64: dts: mt8183: Add kukui-jacuzzi-cerise series boards

From: AngeloGioacchino Del Regno
Date: Wed Jul 31 2024 - 04:21:31 EST


Il 31/07/24 08:26, Hsin-Te Yuan ha scritto:
Cerise is known as ASUS Chromebook CZ1.
Stern is known as ASUS Chromebook Flip CZ1.

They are almost identical. The only difference is that Cerise is a
clamshell device without touchscreen and Stern is a convertible device.

Signed-off-by: Hsin-Te Yuan <yuanhsinte@xxxxxxxxxxxx>
---
arch/arm64/boot/dts/mediatek/Makefile | 4 +++
.../mediatek/mt8183-kukui-jacuzzi-cerise-rev3.dts | 26 +++++++++++++++++++
.../dts/mediatek/mt8183-kukui-jacuzzi-cerise.dts | 26 +++++++++++++++++++
.../dts/mediatek/mt8183-kukui-jacuzzi-cerise.dtsi | 21 ++++++++++++++++
.../mediatek/mt8183-kukui-jacuzzi-stern-rev3.dts | 29 ++++++++++++++++++++++
.../dts/mediatek/mt8183-kukui-jacuzzi-stern.dts | 29 ++++++++++++++++++++++
6 files changed, 135 insertions(+)


..snip..

diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-cerise.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-cerise.dtsi
new file mode 100644
index 000000000000..087a0ef33e13
--- /dev/null
+++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-cerise.dtsi
@@ -0,0 +1,21 @@
+// SPDX-License-Identifier: (GPL-2.0 OR MIT)
+/*
+ * Copyright 2021 Google LLC
+ */
+
+/dts-v1/;
+#include "mt8183-kukui-jacuzzi.dtsi"
+
+&cpu_thermal {
+ sustainable-power = <4500>; /* milliwatts */
+};
+
+&mmc1_pins_uhs {
+ pins-clk {
+ drive-strength = <MTK_DRIVE_6mA>;

Sorry for not noticing that in v1, I have one more nit: please do not use
the MTK_DRIVE_(x)mA definitions.

This is just `drive-strength = <6>`.

Thanks,
Angelo