Re: [PATCH v2] selftests: lib: remove strscpy test

From: Muhammad Usama Anjum
Date: Wed Jul 31 2024 - 04:33:05 EST


On 7/31/24 3:37 AM, Shuah Khan wrote:
> On 7/25/24 06:11, Muhammad Usama Anjum wrote:
>> The strscpy test loads test_strscpy module for testing. But test_strscpy
>> was converted to Kunit (see fixes). Hence remove strscpy.
>>
>> Fixes: 41eefc46a3a4 ("string: Convert strscpy() self-test to KUnit")
>> Signed-off-by: Muhammad Usama Anjum <usama.anjum@xxxxxxxxxxxxx>
>> ---
>> Changes since v1:
>> - Remove from Makefile and config file as well
>> ---
>
> As mentioned in other threads on this conversion to kunit and removal
> of kselfttest - NACK on this patch.
>
> Please don't send me any more of these conversion and removal patches.
This patch is removing a dead kselftest as its corresponding test module
was moved years ago (in 2022). This test has been failing since then. It
seems like misunderstanding that I'm removing something.

>
> thanks,
> -- Shuah
>

--
BR,
Muhammad Usama Anjum