Re: [PATCH v2 2/2] dt-bindings: arm64: mediatek: Add kukui-jacuzzi-cerise board

[Krzysztof Kozlowski]

On 31/07/2024 10:47, AngeloGioacchino Del Regno wrote:
> Il 31/07/24 10:16, Krzysztof Kozlowski ha scritto:
>> On 31/07/2024 08:26, Hsin-Te Yuan wrote:
>>> Cerise is known as ASUS Chromebook CZ1.
>>> Stern is known as ASUS Chromebook Flip CZ1.
>>>
>>> They are almost identical. The only difference is that Cerise is a
>>> clamshell device without touchscreen and Stern is a convertible device.
>>>
>>> Signed-off-by: Hsin-Te Yuan <yuanhsinte@xxxxxxxxxxxx>
>>> ---
>>>   Documentation/devicetree/bindings/arm/mediatek.yaml | 14 ++++++++++++++
>>>   1 file changed, 14 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml
>>> index 1d4bb50fcd8d..087773a43673 100644
>>> --- a/Documentation/devicetree/bindings/arm/mediatek.yaml
>>> +++ b/Documentation/devicetree/bindings/arm/mediatek.yaml
>>> @@ -146,6 +146,20 @@ properties:
>>>           items:
>>>             - const: google,burnet
>>>             - const: mediatek,mt8183
>>> +      - description: Google Cerise (ASUS Chromebook CZ1)
>>> +        items:
>>> +          - enum:
>>> +              - google,cerise-sku0
>>> +              - google,cerise-rev3-sku0
>>> +          - const: google,cerise
>>> +          - const: mediatek,mt8183
>>> +      - description: Google Stern (ASUS Chromebook Flip CZ1)
>>> +        items:
>>> +          - enum:
>>> +              - google,cerise-sku1
>>> +              - google,cerise-rev3-sku1
>>> +          - const: google,cerise
>>
>> Why not google,stern? If this is not compatible with cerise and has
>> different name, I think logical would be to have different compatible -
>> either here or the first one.
>>
> 
> They're both compatible, but the commercial names are different because one
> is convertible, one is not... and the bootloader still checks for cerise
> even on stern - that's how I read it, and it's not the first time...
> 
> ...but it doesn't hurt to have a "google,stern" compatible added to the mix,
> it's just one more const to add... and I don't have any strong opinion about
> that, so, Hsin-Te, it's your call. :-)

OK. Such explanations - including that bootloader expect exactly these
strings - should be in commit msg.

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>


Best regards,
Krzysztof