Re: [PATCH 02/15] usb: typec: tcpm/tcpci_maxim: clarify a comment

From: Heikki Krogerus
Date: Wed Jul 31 2024 - 06:11:30 EST


On Wed, Jul 10, 2024 at 11:36:09AM +0100, André Draszik wrote:
> We loop while the status is != 0, so rephrase the comment slightly for
> clarity.
>
> Signed-off-by: André Draszik <andre.draszik@xxxxxxxxxx>

Reviewed-by: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>

> ---
> drivers/usb/typec/tcpm/tcpci_maxim_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/typec/tcpm/tcpci_maxim_core.c b/drivers/usb/typec/tcpm/tcpci_maxim_core.c
> index eec3bcec119c..87102b4d060d 100644
> --- a/drivers/usb/typec/tcpm/tcpci_maxim_core.c
> +++ b/drivers/usb/typec/tcpm/tcpci_maxim_core.c
> @@ -397,7 +397,7 @@ static irqreturn_t max_tcpci_irq(int irq, void *dev_id)
> }
> while (status) {
> irq_return = _max_tcpci_irq(chip, status);
> - /* Do not return if the ALERT is already set. */
> + /* Do not return if a (new) ALERT is set (again). */
> ret = max_tcpci_read16(chip, TCPC_ALERT, &status);
> if (ret < 0)
> break;
>
> --
> 2.45.2.803.g4e1b14247a-goog

--
heikki