Re: [PATCH 08/15] usb: typec: tcpm/tcpci_maxim: sort TCPC_ALERT_MASK values by bit

[Heikki Krogerus]

On Wed, Jul 10, 2024 at 11:36:15AM +0100, André Draszik wrote:
> This makes it easier to see what's missing and what's being programmed.
> 
> While at it, add brackets to help with formatting and remove a comment
> that doesn't add much value.
> 
> Signed-off-by: André Draszik <andre.draszik@xxxxxxxxxx>

Reviewed-by: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>

> ---
>  drivers/usb/typec/tcpm/tcpci_maxim_core.c | 12 +++++++-----
>  1 file changed, 7 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/usb/typec/tcpm/tcpci_maxim_core.c b/drivers/usb/typec/tcpm/tcpci_maxim_core.c
> index 87102b4d060d..ad9bb61fd9e0 100644
> --- a/drivers/usb/typec/tcpm/tcpci_maxim_core.c
> +++ b/drivers/usb/typec/tcpm/tcpci_maxim_core.c
> @@ -97,11 +97,13 @@ static void max_tcpci_init_regs(struct max_tcpci_chip *chip)
>  	if (ret < 0)
>  		return;
>  
> -	alert_mask = TCPC_ALERT_TX_SUCCESS | TCPC_ALERT_TX_DISCARDED | TCPC_ALERT_TX_FAILED |
> -		TCPC_ALERT_RX_HARD_RST | TCPC_ALERT_RX_STATUS | TCPC_ALERT_CC_STATUS |
> -		TCPC_ALERT_VBUS_DISCNCT | TCPC_ALERT_RX_BUF_OVF | TCPC_ALERT_POWER_STATUS |
> -		/* Enable Extended alert for detecting Fast Role Swap Signal */
> -		TCPC_ALERT_EXTND | TCPC_ALERT_EXTENDED_STATUS | TCPC_ALERT_FAULT;
> +	alert_mask = (TCPC_ALERT_TX_SUCCESS | TCPC_ALERT_TX_DISCARDED |
> +		      TCPC_ALERT_TX_FAILED | TCPC_ALERT_RX_HARD_RST |
> +		      TCPC_ALERT_RX_STATUS | TCPC_ALERT_POWER_STATUS |
> +		      TCPC_ALERT_CC_STATUS |
> +		      TCPC_ALERT_EXTND | TCPC_ALERT_EXTENDED_STATUS |
> +		      TCPC_ALERT_VBUS_DISCNCT | TCPC_ALERT_RX_BUF_OVF |
> +		      TCPC_ALERT_FAULT);
>  
>  	ret = max_tcpci_write16(chip, TCPC_ALERT_MASK, alert_mask);
>  	if (ret < 0) {
> 
> -- 
> 2.45.2.803.g4e1b14247a-goog

-- 
heikki