Re: [PATCH v4] driver:core: no need to invert the return value of the call_driver_probe()
From: Greg KH
Date: Wed Jul 31 2024 - 08:45:48 EST
On Wed, Jul 10, 2024 at 07:00:41AM -0700, 李哲 wrote:
> In the probe function (either drv->bus->probe() or drv->probe()),
> there is no return value of EPROBE_DEFER. the error return from probe
> should be -EPROBE_DEFER, hence no negation of call_driver_probe()'s
> return is needed, nor should there be an EPROBE_DEFER check in
> driver_probe_device()
Are you sure? What makes the logic in commit 45ddcb42949f ("driver
core: Don't return EPROBE_DEFER to userspace during sysfs bind")
incorrect? It required the check for EPROBE_DEFER like this, has
something changed since then to make this test not required?
thanks,
greg k-h