[PATCH v2 0/2] fsconfig: minor fsparam_fd fixes

From: Aleksa Sarai
Date: Wed Jul 31 2024 - 09:11:37 EST


While working on adding an fsparam_fd() argument to cgroupfs, I noticed
that there are only two users of fsparam_fd() and they both seemed to
have minor issues:

* autofs has a missing fput() when using FSCONFIG_SET_FD.
* coda uses fsparam_fd() but it ignores param->file and so ends up
re-getting the file. This doesn't change the behaviour but it seems
preferable to have all users of fsparam_fd() have the same logic.

I have tested this logic for the cgroupfs patch but I have only compile
tested the fixes for autofs and coda.

The second patch is not really required, so feel free to drop it if you
feel the original version was cleaner.

Signed-off-by: Aleksa Sarai <cyphar@xxxxxxxxxx>
---
Changes in v2:
- Fix fs/coda/inode.c build errors.
- Link to v1: https://lore.kernel.org/r/20240719-fsconfig-fsparam_fd-fixes-v1-0-7ccd315c2ad4@xxxxxxxxxx

---
Aleksa Sarai (2):
autofs: fix missing fput for FSCONFIG_SET_FD
coda: use param->file for FSCONFIG_SET_FD

fs/autofs/inode.c | 3 +--
fs/coda/inode.c | 43 ++++++++++++++++++++++++++++++-------------
2 files changed, 31 insertions(+), 15 deletions(-)
---
base-commit: c7b9563b58a77423d4c6e026ff831a69612b02fc
change-id: 20240714-fsconfig-fsparam_fd-fixes-09f2e741c28d

Best regards,
--
Aleksa Sarai <cyphar@xxxxxxxxxx>