Re: [syzbot] Re: [syzbot] [net?] possible deadlock in team_device_event (3)

From: syzbot
Date: Wed Jul 31 2024 - 09:20:28 EST


For archival purposes, forwarding an incoming command email to
linux-kernel@xxxxxxxxxxxxxxx.

***

Subject: Re: [syzbot] [net?] possible deadlock in team_device_event (3)
Author: aha310510@xxxxxxxxx

#syz test git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master

---
net/core/rtnetlink.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c
index 87e67194f240..dc9f9c4dcb49 100644
--- a/net/core/rtnetlink.c
+++ b/net/core/rtnetlink.c
@@ -2903,7 +2903,7 @@ static int do_setlink(const struct sk_buff *skb,
goto errout;
}

- if (tb[IFLA_MASTER]) {
+ if (tb[IFLA_MASTER] && !(dev->flags & IFF_UP)) {
err = do_set_master(dev, nla_get_u32(tb[IFLA_MASTER]), extack);
if (err)
goto errout;
--