Re: [PATCH v1] mm/hugetlb: remove hugetlb_follow_page_mask() leftover

From: Peter Xu
Date: Wed Jul 31 2024 - 11:05:02 EST


On Wed, Jul 31, 2024 at 04:20:00PM +0200, David Hildenbrand wrote:
> We removed hugetlb_follow_page_mask() in commit 9cb28da54643 ("mm/gup:
> handle hugetlb in the generic follow_page_mask code") but forgot to
> cleanup some leftovers.
>
> While at it, simplify the hugetlb comment, it's overly detailed and
> rather confusing. Stating that we may end up in there during coredumping
> is sufficient to explain the PF_DUMPCORE usage.
>
> Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> Cc: Peter Xu <peterx@xxxxxxxxxx>
> Cc: Muchun Song <muchun.song@xxxxxxxxx>
> Cc: Alexander Viro <viro@xxxxxxxxxxxxxxxxxx>
> Cc: Christian Brauner <brauner@xxxxxxxxxx>
> Cc: Jan Kara <jack@xxxxxxx>
> Signed-off-by: David Hildenbrand <david@xxxxxxxxxx>

Reviewed-by: Peter Xu <peterx@xxxxxxxxxx>

--
Peter Xu