Re: [PATCH v2] selftests: ksft: Fix finished() helper exit code on skipped tests

[Shuah Khan]

On 7/31/24 07:05, Muhammad Usama Anjum wrote:
> On 7/30/24 3:29 PM, Laura Nao wrote:
> > The Python finished() helper currently exits with KSFT_FAIL when there
> > are only passed and skipped tests. Fix the logic to exit with KSFT_PASS
> > instead, making it consistent with its C and bash counterparts
> > (ksft_finished() and ktap_finished() respectively).
> >
> > Reviewed-by: Nícolas F. R. A. Prado <nfraprado@xxxxxxxxxxxxx>
> > Fixes: dacf1d7a78bf ("kselftest: Add test to verify probe of devices from discoverable buses")
> > Signed-off-by: Laura Nao <laura.nao@xxxxxxxxxxxxx>
> Reviewed-by: Muhammad Usama Anjum <usama.anjum@xxxxxxxxxxxxx>
>
> > ---
> > This is a revised version of the patch initially submitted as "[PATCH]
> > selftests: ksft: Track skipped tests when finishing the test suite":
> > https://lore.kernel.org/all/20240722154319.619944-1-laura.nao@xxxxxxxxxxxxx/
> >
> > Depends on "[PATCH v2 2/3] kselftest: Move ksft helper module to common
> > directory":
> > https://lore.kernel.org/all/20240705-dev-err-log-selftest-v2-2-163b9cd7b3c1@xxxxxxxxxxxxx/
> > (picked through the usb tree, queued for 6.11-rc1)
> >
> > Changes in v2:
> > - Reworded the commit title and message to more accurately describe the
> > incorrect behavior of the finished() helper addressed by the patch.

Thank you - Applied to linux-kselftest fixes for Linux 6.11-rc2

thanks,
-- Shuah