Re: [net-next v3 14/15] net: marvell: Convert tasklet API to new bottom half workqueue mechanism
From: Allen
Date: Wed Jul 31 2024 - 16:42:32 EST
> > - * Called only from mvpp2_txq_done(), called from mvpp2_tx()
> > - * (migration disabled) and from the TX completion tasklet (migration
> > - * disabled) so using smp_processor_id() is OK.
> > + * Called only from mvpp2_txq_done().
> > + *
> > + * Historically, this function was invoked directly from mvpp2_tx()
> > + * (with migration disabled) and from the bottom half workqueue.
> > + * Verify that the use of smp_processor_id() is still appropriate
> > + * considering the current bottom half workqueue implementation.
>
> What does this mean? You want somebody else to verify this? You are
> potentially breaking this driver?
>
Thanks for providing the review. Apologies for not having worded
this correctly. Russel did ask me to leave it as it was when I first sent out
the series. Perhaps I should do so. Kindly advice.
Thanks,
Allen