Re: [PATCH] net/chelsio/libcxgb: Add __percpu annotations to libcxgb_ppm.c

From: Jakub Kicinski
Date: Wed Jul 31 2024 - 22:09:10 EST


On Wed, 31 Jul 2024 12:06:18 +0200 Uros Bizjak wrote:
> > Let's keep to less than 80 columns wide, as is still preferred for
> > Networking code. Perhaps in this case:
> >
> > static struct cxgbi_ppm_pool __percpu *
> > ppm_alloc_cpu_pool(unsigned int *total, unsigned int *pcpu_ppmax)
>
> Hm, the original is exactly what sparse dumped, IMO code dumps should
> be left as they were dumped.

Unclear to me what you mean by "dumped" here.
Please follow Simon's advice.
--
pw-bot: cr