Re: [PATCH net-next v2] net: mana: Implement get_ringparam/set_ringparam for mana

[Shradha Gupta]

On Wed, Jul 31, 2024 at 02:19:34PM +0530, Naman Jain wrote:
> 
> 
> On 7/30/2024 10:31 PM, Shradha Gupta wrote:
> >Currently the values of WQs for RX and TX queues for MANA devices
> >are hardcoded to default sizes.
> >Allow configuring these values for MANA devices as ringparam
> >configuration(get/set) through ethtool_ops.
> >
> >Signed-off-by: Shradha Gupta <shradhagupta@xxxxxxxxxxxxxxxxxxx>
> >Reviewed-by: Haiyang Zhang <haiyangz@xxxxxxxxxxxxx>
> >Reviewed-by: Long Li <longli@xxxxxxxxxxxxx>
> >---
> >  Changes in v2:
> >  * Removed unnecessary validations in mana_set_ringparam()
> >  * Fixed codespell error
> >  * Improved error message to indicate issue with the parameter
> >---
> >  drivers/net/ethernet/microsoft/mana/mana_en.c | 20 +++---
> >  .../ethernet/microsoft/mana/mana_ethtool.c    | 66 +++++++++++++++++++
> >  include/net/mana/mana.h                       | 21 +++++-
> >  3 files changed, 96 insertions(+), 11 deletions(-)
> >
> 
> From what I understand, we are adding support for "ethtool -G --set-
> ring"  command.
> Please correct me if I am wrong.
> 
> Maybe it would be good to capture the benefit/purpose of this patch in
> the commit msg, as in which use-cases/scenarios we are now trying to
> support that previously were not supported. The "why?" part basically.

Hi Naman,
Thanks for your comment. 
It is a pretty standard support for network drivers to allow changing
TX/RX queue sizes. We are working on improving customizations in MANA
driver based on VM configurations. This patch is a part of that series.
Hope that makes things more clear.

regards,
Shradha
> 
> 
> 
> Regards,
> Naman Jain