Re: [PATCH 0/4] ad7124 fixes and improvements

[Nuno Sá]

On Wed, 2024-07-31 at 15:37 +0300, Dumitru Ceclan wrote:
> This patch series adds fixes and improvements in the ad7124 driver.
> 
> Fixes:
> - properly compare config values
> - add a delay after reset to allow chip initialization
> 
> Improvements:
> - reduce the number of SPI transfers
> - ensure that after probe the ADC is in idle mode
>   and not continuos conversion mode
> 
> Another thing that could be considered is improving the config pop
> behavior as kfifo_get() will return the least recently added config
> instead of the least recently *used* one.
> 
> This could be an issue when multiple channels are using the same "old"
> config and the LRU considers that one as the least recently used.
> 
> If this is considered a valid issue, I can add another patch for it.
> 
> Signed-off-by: Dumitru Ceclan <dumitru.ceclan@xxxxxxxxxx>
> ---

Reviewed-by: Nuno Sa <nuno.sa@xxxxxxxxxx>

> Dumitru Ceclan (4):
>       iio: adc: ad7124: fix chip ID mismatch
>       iio: adc: ad7124: fix config comparison
>       iio: adc: ad7124: reduce the number of SPI transfers
>       iio: adc: ad7124: set initial ADC mode to idle
> 
>  drivers/iio/adc/ad7124.c | 61 ++++++++++++++++++++++++-----------------------
> -
>  1 file changed, 31 insertions(+), 30 deletions(-)
> ---
> base-commit: 380afccc2a55e8015adae4266e8beff96ab620be
> change-id: 20240731-ad7124-fix-37aec7fe0b6b
> 
> Best regards,