Re: [PATCH 2/2] drm/bridge: synopsys: Add DW HDMI QP TX Controller driver

[Krzysztof Kozlowski]

On 01/08/2024 04:05, Cristian Ciocaltea wrote:
> The Synopsys DesignWare HDMI 2.1 Quad-Pixel (QP) TX Controller supports
> the following features, among others:

...

> +
> +void dw_hdmi_qp_unbind(struct dw_hdmi_qp *hdmi)
> +{
> +}
> +EXPORT_SYMBOL_GPL(dw_hdmi_qp_unbind);

This looks like quite useless export. Drop.


> +
> +void dw_hdmi_qp_resume(struct device *dev, struct dw_hdmi_qp *hdmi)
> +{
> +	dw_hdmi_qp_init_hw(hdmi);
> +}
> +EXPORT_SYMBOL_GPL(dw_hdmi_qp_resume);
> +
> +MODULE_AUTHOR("Algea Cao <algea.cao@xxxxxxxxxxxxxx>");
> +MODULE_AUTHOR("Cristian Ciocaltea <cristian.ciocaltea@xxxxxxxxxxxxx>");
> +MODULE_DESCRIPTION("DW HDMI QP transmitter driver");
> +MODULE_LICENSE("GPL");
> +MODULE_ALIAS("platform:dw-hdmi-qp");

That's not a platform driver. That does not look like driver at all,
just some helper code without any user

1. Drop alias.
2. Provide users for this code. You cannot add some helper functions
which nothing uses.
3. Fix subject, commit msg, module description - there is no driver
here, but helper functions. Otherwise how does it bind?

Best regards,
Krzysztof