Re: [PATCH 2/2] drm/bridge: synopsys: Add DW HDMI QP TX Controller driver

[Krzysztof Kozlowski]

On 01/08/2024 11:43, Cristian Ciocaltea wrote:
> On 8/1/24 11:50 AM, Krzysztof Kozlowski wrote:
>> On 01/08/2024 04:05, Cristian Ciocaltea wrote:
>>> The Synopsys DesignWare HDMI 2.1 Quad-Pixel (QP) TX Controller supports
>>> the following features, among others:
>>
>> ...
>>
>>> +
>>> +void dw_hdmi_qp_unbind(struct dw_hdmi_qp *hdmi)
>>> +{
>>> +}
>>> +EXPORT_SYMBOL_GPL(dw_hdmi_qp_unbind);
>>
>> This looks like quite useless export. Drop.
>>
>>
>>> +
>>> +void dw_hdmi_qp_resume(struct device *dev, struct dw_hdmi_qp *hdmi)
>>> +{
>>> +	dw_hdmi_qp_init_hw(hdmi);
>>> +}
>>> +EXPORT_SYMBOL_GPL(dw_hdmi_qp_resume);
>>> +
>>> +MODULE_AUTHOR("Algea Cao <algea.cao@xxxxxxxxxxxxxx>");
>>> +MODULE_AUTHOR("Cristian Ciocaltea <cristian.ciocaltea@xxxxxxxxxxxxx>");
>>> +MODULE_DESCRIPTION("DW HDMI QP transmitter driver");
>>> +MODULE_LICENSE("GPL");
>>> +MODULE_ALIAS("platform:dw-hdmi-qp");
>>
>> That's not a platform driver. That does not look like driver at all,
>> just some helper code without any user
> 
> This is actually used to provide RK3588 HDMI output support:
> 
> https://lore.kernel.org/lkml/20240801-b4-rk3588-bridge-upstream-v2-3-9fa657a4e15b@xxxxxxxxxxxxx/

That is supposed to be in one patchset, so we can see how you use the
introduced functions.


Best regards,
Krzysztof